Only check for .dist-info directories at the top-level #7519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrahunt
added
skip news
Previously we were restricting to a single .dist-info directory anywhere in the unpacked wheel directory. That was incorrect since only a top-level .dist-info directory indicates a contained "package". Now we limit our restriction to top-level .dist-info directories.
chrahunt
force-pushed
the
bugfix/restrict-two-dist-info-dirs-toplevel-only
branch
from
22f5136 to
93900e1
Compare
pradyunsg
approved these changes
Dec 29, 2019
chrahunt
deleted the
bugfix/restrict-two-dist-info-dirs-toplevel-only
branch
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were restricting to a single .dist-info directory anywhere
in the unpacked wheel directory. That was incorrect since only a
top-level .dist-info directory indicates a contained "package". Now we
limit our restriction to top-level .dist-info directories, which was the intent in #7494.
As mentioned in #7494 (comment).
Marking as trivial since this prior change was unreleased.