Remove redundant expanduser for download_dir in preparer #7535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since - download_dir is only set by the download command - download_dir is normalized at the beginning of the download command - path normalization includes expanduser Therefore expanduser in the preparer is redundant
xavfernandez
approved these changes
Jan 1, 2020
|
Thanks for following up :) |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following from #7524 (comment)
Since
download_dirpreparer attribute is only set by the download commanddownload_diris normalized at the beginning of the download commandnormalize_pathincludesexpanduserTherefore expanduser in the preparer is redundant