Canonicalise package name in tests.lib.create_basic_wheel_for_package #8067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deveshks
force-pushed
the
fix-create-basic-wheel-bug
branch
from
a9b1dae to
7bcccbd
Compare
|
I ended up creating a test in I didn't use a package name with dot since I was a little confused. On one hand, the regex present at PEP-491 Escaping and Unicode tells me that having a dot in a wheel file is valid since we don't strip it out from a package name, and on the other hand, as per #8054 (comment) , having a dot in a wheel file name is invalid. |
deveshks
force-pushed
the
fix-create-basic-wheel-bug
branch
from
87cb86e to
b60b0f3
Compare
deveshks
force-pushed
the
fix-create-basic-wheel-bug
branch
from
b60b0f3 to
22878a8
Compare
xavfernandez
approved these changes
Apr 20, 2020
|
Thanks @xavfernandez for the approval. Will this be merged post the new pip release? |
uranusjr
approved these changes
Apr 26, 2020
pfmoore
approved these changes
May 21, 2020
|
Thanks for the fix! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes and closes #8064
Use a canonical package name while creating the wheel file name in
tests.lib.create_basic_wheel_for_packageusing PEP 491 Escaping and Unicode.Since it's a bug fix in the unit tests and won't affect the end-user, marking it as trivial.