Skip to content

Pass revision to 'hg clone' command when cloning Mercurial repository. #8222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

manueljacob
Copy link

This ensures that only the required changesets are pulled from the server.

Some servers don’t advertise all changesets by default. An example is
Heptapod, to ensure that changesets with so-called "topics" are only cloned by
clients which know how to handle them. Passing the revision enables that these
changesets can be cloned anyway. Whether they have a "topic" or not is not
relevant to us.

@manueljacob manueljacob force-pushed the pass_rev_to_hg_clone branch 5 times, most recently from cccb213 to 980bc65 Compare May 12, 2020 02:50
@manueljacob manueljacob marked this pull request as draft May 12, 2020 03:26
@manueljacob manueljacob force-pushed the pass_rev_to_hg_clone branch from 980bc65 to 44d3fbe Compare May 12, 2020 08:11
@manueljacob manueljacob marked this pull request as ready for review May 12, 2020 08:41
@manueljacob
Copy link
Author

Some linter CI runs fail because of flake8 warnings in unrelated files. In some environments, flake8 passes. I guess this is unrelated to my changes.

@pradyunsg
Copy link
Member

Hi @manueljacob! Thanks for the PR! ^>^

You're correct, that happened because of not-in-this-PR changes. We've merged #8227 which should fix this issue, so rebasing on top of master (or merging master) should fix the linting failures. :)

@pradyunsg pradyunsg added C: vcs pip's interaction with version control systems like git, svn and bzr state: needs eyes Needs a maintainer/triager to take a closer look type: enhancement Improvements to functionality labels May 12, 2020
@pradyunsg
Copy link
Member

I am not familiar with svn, so I'm not going to be able to review this PR. :)

Manuel Jacob added 2 commits May 13, 2020 00:08
This ensures that only the required changesets are pulled from the server.

Some servers don’t advertise all changesets by default. An example is
Heptapod, to ensure that changesets with so-called "topics" are only cloned by
clients which know how to handle them. Passing the revision enables that these
changesets can be cloned anyway. Whether they have a "topic" or not is not
relevant to us.
@manueljacob manueljacob force-pushed the pass_rev_to_hg_clone branch from 44d3fbe to 5c9e2be Compare May 12, 2020 22:09
@manueljacob manueljacob changed the title Pass revision to 'hg clone' command. Pass revision to 'hg clone' command when cloning Mercurial repository. May 12, 2020
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Feb 18, 2021
@pradyunsg
Copy link
Member

Closing since this is out of date and bitrotten. Please feel free to file a new PR for this! ^>^

@pradyunsg pradyunsg closed this Apr 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: vcs pip's interaction with version control systems like git, svn and bzr needs rebase or merge PR has conflicts with current master state: needs eyes Needs a maintainer/triager to take a closer look type: enhancement Improvements to functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants