-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add methods for path lookups in test_install_{extras, index}.py #8326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've not provided the message arguments at some places. That's the only thing I guess, which is left, else LGTM :) Please correct if I get some reviews wrong.
Please find the reviews inline.
@deveshks @gutsytechster , Thank you for the review, will make these changes! |
I don't think any of the suggested changes are appropriate. All of them are suggesting setting
Instances like these, where not-all-the-relevant-info messages were provided through the assertion are spread across the test suite ( |
I was thinking somewhat the same, but wasn't confident. |
Eh! Thanks for correcting. I'll update my PR as well. :P |
f5a9323
to
57a0815
Compare
towards #6050