Add methods for path lookups in test_install_{vcs_git, wheel}.py #8345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
reviewed
May 28, 2020
pradyunsg
reviewed
May 28, 2020
| @@ -511,9 +495,9 @@ def test_install_from_wheel_uninstalls_old_version(script, data): | |||
| package = data.packages.joinpath("simplewheel-2.0-py2.py3-none-any.whl") | |||
| result = script.pip('install', package, '--no-index') | |||
| dist_info_folder = script.site_packages / 'simplewheel-2.0.dist-info' | |||
| assert dist_info_folder in result.files_created | |||
| result.did_create(dist_info_folder) | |||
| dist_info_folder = script.site_packages / 'simplewheel-1.0.dist-info' | |||
There was a problem hiding this comment.
We should have a follow up PR that changes the variable names in this test, to clearly indicate what is "setup" and what's checking the behavior here, and also check that things get deleted.
There was a problem hiding this comment.
Agreed. I'll create a PR once this gets merged. :)
pradyunsg
approved these changes
May 31, 2020
sbidoul
approved these changes
Jun 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #6050