Fix direct URL by always passing the template’s URL values into candidate #8378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to set the original link so the value is accessible in later code, when we return the ireq backing the candidate. This is needed for some parts of the post processing like PEP 610 support, which needs to record the original, remote URL, not the potentially hit cache link.
uranusjr
added
skip news
|
This seems to work. |
sbidoul
reviewed
Jun 2, 2020
sbidoul
approved these changes
Jun 2, 2020
pfmoore
approved these changes
Jun 3, 2020
|
@pradyunsg Do you want to review this, or should I merge it? |
|
Go ahead. I don't think I'll be able to take a look today. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix
test_install_vcs_non_editable_direct_url, but this must not break any passing tests…