Handle invalid requirement as parameter to uninstall #9052

GuyTuval · 2020-10-25T23:37:34Z

Implemented error handling when passing a URL or an archive to pip uninstall.
The current implementation, when given a list of libraries in pip uninstall, will not uninstall any library if at least one of them is an archive or a URL.

NoahGorny

Just a minor comment, otherwise LGTM

src/pip/_internal/commands/uninstall.py

xavfernandez

You will also have to rebase your PR on master to fix the CI 👍

src/pip/_internal/commands/uninstall.py

xavfernandez

script.pip is a special helper that actually spawn a process.

tests/functional/test_uninstall.py

GuyTuval · 2020-11-05T21:25:11Z

script.pip is a special helper that actually spawn a process.

Roger that, @xavfernandez. How do I rebase my PR on master, so the CI will get fixed and I will be allowed to merge? :)

xavfernandez · 2020-11-06T14:13:50Z

Roger that, @xavfernandez. How do I rebase my PR on master, so the CI will get fixed and I will be allowed to merge? :)

something like:

git fetch origin
git checkout failed-uninstall-parameter-4958
git rebase origin/master
git push GuyTuval failed-uninstall-parameter-4958 -f

should work (given that origin remote is https://github.com/pypa/pip/ and GuyTuval remote is https://github.com/GuyTuval/pip).

GuyTuval · 2020-11-20T18:57:22Z

Hi @xavfernandez ! 😃
It seems the requested changes haven't been approved yet.
Can you check if they are all met and approve/disapprove accordingly?

news/4958.feature.rst

src/pip/_internal/commands/uninstall.py

GuyTuval · 2021-01-29T15:31:55Z

Hi @uranusjr 😁
Would you mind reviewing this PR? I believe it offers a nice improvement to uninstall command

GuyTuval · 2021-02-04T18:26:47Z

Hi @pradyunsg, I am humbly pumping this PR as I don't want it to get lost.
Can you review/merge the PR?

pradyunsg · 2021-02-06T09:12:52Z

Thanks for the nudge here @GuyTuval! :)

tests/functional/test_uninstall.py

BrownTruck · 2021-02-19T19:46:44Z

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

GuyTuval · 2021-02-25T23:17:03Z

Hi @pradyunsg!
Is it possible to merge this PR?
If there is a reason I'm not aware of that postpones the merge of this PR I would appreciate it if you lmk 😅

adds VERBOSE custom log level between DEBUG and INFO used when `-v` is given. Now require -vv to enable full debug output. Messages can be logged with VERBOSE level to promote them to `-v` output instead of `-vv`

The UTF-8 encoding was assumed in an sdist, but without explicit specifying, extraction may fail on obscure systems where the default encoding is not UTF-8. Co-Authored-By: Chris Hunt <[email protected]>

The practical difference is the mismatch detection is not performed at most once for every invocation, thus only warned once if there are any mismatches.

GuyTuval · 2021-04-30T15:58:19Z

Hello @pradyunsg !
Would you mind merging this PR? I have fixed every given CR and don't want it to get forgotten 😅

Co-authored-by: Pradyun Gedam <[email protected]>

POSIX is problematic when the environment is not configured properly.

In pip 20.3, the new resolver will be the default. Therefore, this commit updates user docs to change instructions for testing, migration, etc. Towards #8937.

Related to #9020.

…stall' command.

Co-authored-by: Xavier Fernandez <[email protected]>

…958' into failed-uninstall-parameter-4958

GuyTuval marked this pull request as ready for review October 26, 2020 16:00

NoahGorny reviewed Oct 26, 2020

View reviewed changes

src/pip/_internal/commands/uninstall.py Outdated Show resolved Hide resolved

NoahGorny approved these changes Oct 26, 2020

View reviewed changes

xavfernandez requested changes Oct 28, 2020

View reviewed changes

src/pip/_internal/commands/uninstall.py Outdated Show resolved Hide resolved

GuyTuval mentioned this pull request Oct 28, 2020

Implement Uninstall [URL] #4958

Open

xavfernandez reviewed Oct 30, 2020

View reviewed changes

src/pip/_internal/commands/uninstall.py Outdated Show resolved Hide resolved

xavfernandez requested changes Oct 31, 2020

View reviewed changes

src/pip/_internal/commands/uninstall.py Outdated Show resolved Hide resolved

xavfernandez reviewed Nov 5, 2020

View reviewed changes

tests/functional/test_uninstall.py Outdated Show resolved Hide resolved

tests/functional/test_uninstall.py Outdated Show resolved Hide resolved

GuyTuval changed the title ~~Handle archives and URLs as parameters to uninstall~~ Handle invalid requirement as parameter to uninstall Nov 6, 2020

GuyTuval requested a review from xavfernandez November 25, 2020 18:03

xavfernandez reviewed Nov 27, 2020

View reviewed changes

news/4958.feature.rst Outdated Show resolved Hide resolved

src/pip/_internal/commands/uninstall.py Outdated Show resolved Hide resolved

Clean up my Git entries

49fd5db

pradyunsg reviewed Dec 27, 2020

View reviewed changes

src/pip/_internal/commands/uninstall.py Outdated Show resolved Hide resolved

GuyTuval requested a review from pradyunsg December 31, 2020 16:17

pradyunsg approved these changes Feb 6, 2021

View reviewed changes

gst reviewed Feb 6, 2021

View reviewed changes

tests/functional/test_uninstall.py Outdated Show resolved Hide resolved

BrownTruck added the needs rebase or merge PR has conflicts with current master label Feb 19, 2021

pypa-bot removed the needs rebase or merge PR has conflicts with current master label Feb 21, 2021

minrk and others added 3 commits March 12, 2021 13:12

-v shows subprocess output

9b3e784

adds VERBOSE custom log level between DEBUG and INFO used when `-v` is given. Now require -vv to enable full debug output. Messages can be logged with VERBOSE level to promote them to `-v` output instead of `-vv`

Always open tar files with UTF-8

dc9efc8

The UTF-8 encoding was assumed in an sdist, but without explicit specifying, extraction may fail on obscure systems where the default encoding is not UTF-8. Co-Authored-By: Chris Hunt <[email protected]>

Cache location calculation functions

6123570

The practical difference is the mismatch detection is not performed at most once for every invocation, thus only warned once if there are any mismatches.

sbidoul and others added 28 commits July 18, 2021 19:58

Update news/8996.bugfix.rst

dab4275

Co-authored-by: Pradyun Gedam <[email protected]>

Remove --build-dir option, as per deprecation

4e97231

Add news entry

06697c6

Only do the ensure_text() dance on Windows

61a08dd

POSIX is problematic when the environment is not configured properly.

Support multiple abi and platform values for pip download.

728f2a9

Use 'append'-style CLI arguments, rather than ','-separated values.

154417b

Rename news-file to use new *.rst convention.

e7ddd7b

📰

ae720d3

Update user guide to change resolver default

36b7527

In pip 20.3, the new resolver will be the default. Therefore, this commit updates user docs to change instructions for testing, migration, etc. Towards #8937.

Improve docs on resolver, constraints, and hash-checking

f04b3fe

Related to #9020.

Test against Python 3.9 on Travis CI

7d97363

📰

646d0e4

Skip tests that fail on Python 2

62ce4cf

Change where the 2020 resolver warning is logged

100280e

Explicitly state that pip/_vendor/vendor.txt should be available

9c05f8c

Add --exclude option to pip freeze and pip list commands

02076a6

Bump for release

7dd5088

Use packaging.version to check version equality

448cfb6

tests: uninstall: Added tests for archive and URL parameters to 'unin…

0553385

…stall' command.

uninstall: Added news entry for 'uninstall' with archive/URL parameters.

f3b67ec

Update news/4958.feature.rst

40815ee

Co-authored-by: Xavier Fernandez <[email protected]>

Update src/pip/_internal/commands/uninstall.py

adfdf09

Co-authored-by: Xavier Fernandez <[email protected]>

Update pip/tests/functional/test_uninstall.py.

73ceb8e

fork sync.

1a2795e

Refactored tests to use pytest parametrize and f-strings.

f5f2f6c

Fixed missing import and moved to f-strings.

aef9f12

Fix fork sync merge.

40aa517

Merge remote-tracking branch 'origin_old/failed-uninstall-parameter-4…

3aa6a6a

…958' into failed-uninstall-parameter-4958

GuyTuval closed this Jul 18, 2021

github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle invalid requirement as parameter to uninstall #9052

Handle invalid requirement as parameter to uninstall #9052

GuyTuval commented Oct 25, 2020 •

edited

Loading

NoahGorny left a comment

xavfernandez left a comment

xavfernandez left a comment

GuyTuval commented Nov 5, 2020

xavfernandez commented Nov 6, 2020

GuyTuval commented Nov 20, 2020

GuyTuval commented Jan 29, 2021

GuyTuval commented Feb 4, 2021

pradyunsg commented Feb 6, 2021

BrownTruck commented Feb 19, 2021

GuyTuval commented Feb 25, 2021

GuyTuval commented Apr 30, 2021

Handle invalid requirement as parameter to uninstall #9052

Handle invalid requirement as parameter to uninstall #9052

Conversation

GuyTuval commented Oct 25, 2020 • edited Loading

NoahGorny left a comment

Choose a reason for hiding this comment

xavfernandez left a comment

Choose a reason for hiding this comment

xavfernandez left a comment

Choose a reason for hiding this comment

GuyTuval commented Nov 5, 2020

xavfernandez commented Nov 6, 2020

GuyTuval commented Nov 20, 2020

GuyTuval commented Jan 29, 2021

GuyTuval commented Feb 4, 2021

pradyunsg commented Feb 6, 2021

BrownTruck commented Feb 19, 2021

GuyTuval commented Feb 25, 2021

GuyTuval commented Apr 30, 2021

GuyTuval commented Oct 25, 2020 •

edited

Loading