Modernize Python syntax using pyupgrade --py36-plus
#9342
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't add a news file as I feel this is already covered by: But I can certainly add one if preferred. |
pradyunsg
added
the
skip news
|
Can this be done a few files at a time, or one feature at a time instead? Not all of the changes are straightforward (e.g. I would want to manually check encoding changes), but there’s no viable way to review this in one go. |
|
A good way to split this would be how Black's ignore rules are set up in pre-commit's configuration. |
pyupgrade is a tool to automatically upgrade syntax for newer versions of the language. For more details, see: https://github.com/asottile/pyupgrade To keep the diff small, this change doesn't include Python 3.6+ syntax features. The `src/pip/_vendor` and `tests/data` directories were excluded.
- Drop object in class definitions. - Replace `EnvironmentError` and `IOError` with `OSError`. These were unified in Python 3. - Use `yield from` syntax. - Convert simple Python formatting to use f-strings. - Use updated updated `TypedDict` syntax. - Drop 'utf-8' as the argument to `.encode()`/`.decode()`. In Python 3, this is the default. The `src/pip/_vendor` and `tests/data` directories were excluded. pyupgrade is a tool to automatically upgrade syntax for newer versions of the language. For more details, see: https://github.com/asottile/pyupgrade
|
I think a separate PR doing f-strings would clear up most/all of this diff? |
👍 Definitely. I'll close this and handle individual set of changes separately. F-strings handled in #9361 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__future__imports.codecs.open()andio.open()with builtinopen(). In Python 3, these are equivalent.super().EnvironmentErrorandIOErrorwithOSError. These were unified in Python 3.yield fromsyntax.TypedDictsyntax..encode()/.decode(). In Python 3, this is the default.The
src/pip/_vendorandtests/datadirectories were excluded.pyupgrade is a tool to automatically upgrade syntax for newer versions of the language. For more details, see:
https://github.com/asottile/pyupgrade