Skip to content

Remove unused wheel_cache argument in freeze operation #9418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2021
Merged

Remove unused wheel_cache argument in freeze operation #9418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93a51f1
The freeze operation does not need a wheel_cache
sbidoul Jan 2, 2021
e76eadc
Pass freeze() kwargs directly
sbidoul Jan 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions src/pip/_internal/commands/freeze.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
import sys

from pip._internal.cache import WheelCache
from pip._internal.cli import cmdoptions
from pip._internal.cli.base_command import Command
from pip._internal.cli.status_codes import SUCCESS
from pip._internal.models.format_control import FormatControl
from pip._internal.operations.freeze import freeze
from pip._internal.utils.compat import stdlib_pkgs
from pip._internal.utils.deprecation import deprecated
Expand Down Expand Up @@ -78,8 +76,6 @@ def add_options(self):

def run(self, options, args):
# type: (Values, List[str]) -> int
format_control = FormatControl(set(), set())
wheel_cache = WheelCache(options.cache_dir, format_control)
skip = set(stdlib_pkgs)
if not options.freeze_all:
skip.update(DEV_PKGS)
Expand All @@ -97,18 +93,15 @@ def run(self, options, args):
issue=9069,
)

freeze_kwargs = dict(
for line in freeze(
requirement=options.requirements,
find_links=options.find_links,
local_only=options.local,
user_only=options.user,
paths=options.path,
isolated=options.isolated_mode,
wheel_cache=wheel_cache,
skip=skip,
exclude_editable=options.exclude_editable,
)

for line in freeze(**freeze_kwargs):
):
sys.stdout.write(line + '\n')
return SUCCESS
3 changes: 0 additions & 3 deletions src/pip/_internal/operations/freeze.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@

from pip._vendor.pkg_resources import Distribution, Requirement

from pip._internal.cache import WheelCache

RequirementInfo = Tuple[Optional[Union[str, Requirement]], bool, List[str]]


Expand All @@ -48,7 +46,6 @@ def freeze(
user_only=False, # type: bool
paths=None, # type: Optional[List[str]]
isolated=False, # type: bool
wheel_cache=None, # type: Optional[WheelCache]
exclude_editable=False, # type: bool
skip=() # type: Container[str]
):
Expand Down