Pull in typing information from ResolveLib #9699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
added
the
type: maintenance
uranusjr
commented
Mar 8, 2021
uranusjr
commented
Mar 8, 2021
| error = self.factory.get_installation_error( | ||
| cast("ResolutionImpossible[Requirement, Candidate]", e), | ||
| constraints, | ||
| ) |
There was a problem hiding this comment.
Is there a better way to handle the type of e? ResolutionImpossible is a generic exception, but I’m not sure how to specify the type variables here.
uranusjr
force-pushed
the
resolvelib-types
branch
from
5802d21 to
7b2478e
Compare
uranusjr
added
the
skip news
uranusjr
force-pushed
the
resolvelib-types
branch
2 times, most recently
from
e1019b9 to
b0842fe
Compare
This was referenced Mar 9, 2021
|
Waiting for #9700. |
4 tasks
uranusjr
force-pushed
the
resolvelib-types
branch
from
087bb31 to
dea6acc
Compare
uranusjr
added
project: vendored dependency
|
Hello! I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the |
uranusjr
force-pushed
the
resolvelib-types
branch
from
b337f94 to
9ceabb5
Compare
|
I’m going to merge this later today. |
pradyunsg
reviewed
Apr 3, 2021
| error = self.factory.get_installation_error( | ||
| cast("ResolutionImpossible[Requirement, Candidate]", e), | ||
| constraints, | ||
| ) |
|
Er, the news bot is stuck for some reason. |
uranusjr
added
skip news
|
That works. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResolveLib now distributes
.pyitype stubs and uses generics to enforce type safety on provider hooks. Pull in and use them.This PR should not contain any run-time behavioural change.