Solution for upgrading to the new setuptools #992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assert initools_folder in result.files_created, str(result) | ||
|
|
||
|
|
||
| #def test_distutils_configuration_setting(): |
There was a problem hiding this comment.
Did you mean to comment all of this out?
There was a problem hiding this comment.
this test has existed commented out for awhile. I don't know the history.
In the recent test refactor I did, I had removed this test, but in the conflict/merge for this pull, it crept back in somehow.
There was a problem hiding this comment.
I'll delete it back out again, before merging.
|
setuptools-0.8 is soon to be out (and is 2&3 compatible), which allows us to remove some of the hacks in this pull. |
qwcode
added a commit
that referenced
this pull request
Jun 20, 2013
Solution for upgrading to the new setuptools
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pull contains a pip-only solution for upgrading to the new setuptools
(i.e. no more changes required to distribute-0.7 or setuptools-0.7.2)
If Jason releases setuptools-0.8 (that's 2&3 compat), then part of these changes could be removed. Additionally, if Jason decided to proceed with the setuptools-import hack he mentioned in #986, then I think none of this would be required.
posting this as a draft for now, because I'm too tired to look at it or refine it anymore more at the moment, but I think it's working.
I tried a few different solutions (none pretty). This is where I ended up.
these scenarios work (i.e. they result in setuptools-0.7.2 installed):
pip install -U distribute(I was using --find-links locally to find a local sdist of distribute-0.7)pip install -U setuptoolsthe change, in brief (read #986 or the code comments if you need more backstory)
this pull is against develop. if we wanted it in a patch, then I could rework against 1.3.X.