-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Require “--python” values to exist #1864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
76651d5
to
a07e0d6
Compare
This is still WIP so I might be commenting too early, but aside from absolute path |
@uranusjr Yes — I ended up with a more conservative approach of only validating things which appear to be absolute paths to avoid that. It's worked in limited local testing but I'm still waiting for the test suite to finish running. |
hey @acdha when you get a second can you update w/ current master so we can get tests running against this? |
p.s sorry for the delay, tests were very broken (also sorry for the enormous pull you are going to have to do) |
If you could revisit this at some point it would certainly make a good addition! |
This makes it easier for someone to realize when they have provided an invalid Python path without missing that message due to the sizable virtualenv traceback which follows it. I first encountered this when someone copy-and-pasted the example from the Conda documentation which has `--python=/path/to/anaconda/python`. See pypa#1862
98abb5d
to
e3ee7fb
Compare
Sorry about the delays — I'm on parental leave the moment and don't have too much brainpower left for open-source 😀 I rebased it against master and the tests are passing now on Travis so I removed the WIP prefix |
Congrats and thanks a bunch! P.S. We actually met at a conference at the LoC a long time ago, Back then I was working as the 'Curator of Executable Content' on an archive project, small world! |
Ah, small world indeed! If you're ever near LC, feel free to stop by for
coffee.
Chris
|
This makes it easier for someone to realize when they have provided an invalid Python path without missing that message due to the sizable virtualenv traceback which follows it. I first encountered this when someone copy-and-pasted the example from the Conda documentation which has
--python=/path/to/anaconda/python
.See #1862