Skip to content

allow specifying the seed packages #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

allow specifying the seed packages #1353

wants to merge 1 commit into from

Conversation

gaborbernat
Copy link
Contributor

@gaborbernat gaborbernat commented May 4, 2019

i have a dream

- still obey the no setuptools/wheel/pip command
- empty seed packages are removed
- move from optargs to argparse
@gaborbernat gaborbernat added this to the 17.0.0 milestone Jun 3, 2019
@gaborbernat
Copy link
Contributor Author

Withdrawn.

@gaborbernat gaborbernat deleted the ver branch January 18, 2020 17:38
@sinoroc
Copy link

sinoroc commented May 21, 2020

Am I understanding this correctly that the original intention of that change was to allow users to specify wheels (in addition to pip, setuptools, and wheel) that would be seeded into the virtual environment?

@gaborbernat
Copy link
Contributor Author

Yes. However, in the end, we decided against this, and now only allow specifying the exact version constraint for pip/setuptools/wheel. Note one could write a plugin for virtualenv that triggers extra seed packages post environment creation, that now can be installed via pip.

@sinoroc
Copy link

sinoroc commented May 21, 2020

That answers the question. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants