Call towncrier via python instead of doing poor path reconstruction #1848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1848 +/- ##
=======================================
Coverage 88.84% 88.84%
=======================================
Files 82 82
Lines 3946 3946
=======================================
Hits 3506 3506
Misses 440 440
Continue to review full report at Codecov.
|
gaborbernat
force-pushed
the
towncrier-no-path
branch
2 times, most recently
from
f4bada0 to
7af0d58
Compare
Trying to append an executable suffix to towncrier does not work on Linux, as it can create absurd names like `towncrier.7` (`.7` coming from `python3.7`). Let's instead call it via `python -m towncrier`. This should avoid relying on correct `PATH` (as I presume the original code is meant to), while working correctly on all systems and not requiring Python and towncrier to reside in the same directory. Fixes pypa#1847 Signed-off-by: Bernat Gabor <[email protected]>
gaborbernat
force-pushed
the
towncrier-no-path
branch
from
7af0d58 to
5cc2e58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to append an executable suffix to towncrier does not work
on Linux, as it can create absurd names like
towncrier.7(.7comingfrom
python3.7). Let's instead call it viapython -m towncrier.This should avoid relying on correct
PATH(as I presume the originalcode is meant to), while working correctly on all systems
and not requiring Python and towncrier to reside in the same directory.
Fixes #1847
Thanks for contributing, make sure you address all the checklists (for details on how see
development documentation)!
tox -e fix_lint)docs/changelogfolder