2FA basic auth notification email #13831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewdurbin
approved these changes
Jun 1, 2023
| @@ -2593,8 +2594,17 @@ def test_upload_succeeds_with_2fa_enabled( | |||
| IMetricsService: metrics, | |||
| }.get(svc) | |||
|
|
|||
| legacy.file_upload(db_request) | |||
| with pytest.raises(BasicAuthTwoFactorEnabled) as excinfo: | |||
There was a problem hiding this comment.
probably change name of this test now
There was a problem hiding this comment.
Eh? Is the change to test_basic_auth_upload_fails_with_2fa_enabled not sufficient?
Agreed this should eventually be part of the policy, but I think that should probably happen when enforcement is global and not conditional for some users/projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates #13830 so that the 2FA notification email on upload to still sends, with updated content.