Implement initial rollout of PEP 715 #14017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test isn't passing yet.
if someone has a direct Role and a TeamRole we don't want to bother them twice
woodruffw
reviewed
Jun 26, 2023
Co-authored-by: William Woodruff <[email protected]>
miketheman
approved these changes
Jun 26, 2023
Comment on lines
+529
to
+533
| contributors += project.organization.owners | ||
| for teamrole in project.team_project_roles: | ||
| contributors += teamrole.team.members | ||
|
|
||
| for contributor in sorted(set(contributors)): |
There was a problem hiding this comment.
thought: I've seen this kind of pattern a couple of times now, so we likely want to queue up a feature request for Project.all_members or such that figures this out.
There was a problem hiding this comment.
I agree, I think Project.contributors would fit nicely since thats how it is used most frequently.
Also an update to User.projects would be a step towards #13840
There was a problem hiding this comment.
I'd suggest both of those are addressed in a separate PR. (This use case is temporary).
There was a problem hiding this comment.
Of course! I use Conventional Comments for code reviews.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.