Skip to content

feat: hcaptcha service #15141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 5, 2024
Merged

feat: hcaptcha service #15141

merged 3 commits into from
Jan 5, 2024

Conversation

miketheman
Copy link
Member

Will only be activated if the CAPTCHA_BACKEND envvar is set, pointed
to this class.
Before doing that, set the site key and secret key values as well.

Since the name differs by implementation, move it to the class so we can
swap it out as needed.

Signed-off-by: Mike Fiedler <[email protected]>
Also correct type hints.

Signed-off-by: Mike Fiedler <[email protected]>
Will only be activated if the `CAPTCHA_BACKEND` envvar is set, pointed
to this class.
Before doing that, set the site key and secret key values as well.

Signed-off-by: Mike Fiedler <[email protected]>
@miketheman miketheman added the security Security-related issues and pull requests label Jan 4, 2024
@miketheman miketheman requested a review from a team as a code owner January 4, 2024 20:29
@miketheman miketheman merged commit 5261657 into pypi:main Jan 5, 2024
@miketheman miketheman deleted the miketheman/hcaptcha branch January 5, 2024 14:01
Copy link

sentry-io bot commented Jan 6, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ UnexpectedError: Response missing 'error-codes' key: {'success': False, 'challenge_ts': '2024-01-10T08:03:55.33695... accounts.register View Issue
  • ‼️ InvalidInputResponseError accounts.register View Issue
  • ‼️ InvalidOrAlreadySeenResponseError accounts.register View Issue

Did you find this useful? React with a 👍 or 👎

miketheman added a commit to miketheman/warehouse that referenced this pull request Jan 8, 2024
Missed during implementation.

Refs: pypi#15141
Fixes WAREHOUSE-STAGING-P2

Signed-off-by: Mike Fiedler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security Security-related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants