feat(dev): alembic check #16483
Merged
feat(dev): alembic check #16483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketheman
added
testing
1 task
|
Upon review, we added the ability to skip the check if a label is applied, and thus make this a required check. |
miketheman
force-pushed
the
miketheman/alembic-check
branch
10 times, most recently
from
a715fa5 to
8b6c464
Compare
Implements wrapper for `check` command. Refs: https://alembic.sqlalchemy.org/en/latest/autogenerate.html#running-alembic-check-to-test-for-new-upgrade-operations Refs: https://alembic.sqlalchemy.org/en/latest/api/commands.html#alembic.command.check Signed-off-by: Mike Fiedler <[email protected]>
Signed-off-by: Mike Fiedler <[email protected]>
Signed-off-by: Mike Fiedler <[email protected]>
miketheman
force-pushed
the
miketheman/alembic-check
branch
2 times, most recently
from
9022510 to
2a60833
Compare
|
You can see a failing run here, where I introduce a code change that has no associated migration. |
Signed-off-by: Mike Fiedler <[email protected]>
di
reviewed
Aug 15, 2024
di
reviewed
Aug 15, 2024
di
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements wrapper for
checkcommand.Refs: https://alembic.sqlalchemy.org/en/latest/autogenerate.html#running-alembic-check-to-test-for-new-upgrade-operations
Refs: https://alembic.sqlalchemy.org/en/latest/api/commands.html#alembic.command.check
Signed-off-by: Mike Fiedler [email protected]