-
Notifications
You must be signed in to change notification settings - Fork 1k
Package update feed #2165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package update feed #2165
Changes from 8 commits
de561fb
0b6699d
9fa944e
d8b791b
a651185
badbf1d
c67418a
9ac9786
3ea0c3e
2b794a0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
{% extends "base.xml" %} | ||
{% block title %}Latest releases of the {{ project.name }} package{% endblock %} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nitpick: this should probably say "project", not package. It would be good to put the project name in quotes too. |
||
{% block description %}Latest releases of the {{ project.name }} to the Python Package Index{% endblock %} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here, let's add quotes and "project". |
||
{% block link %}{{ request.route_url('packaging.project', name=project.name) }}{% endblock %} | ||
{% block items %} | ||
{% for release in project.releases %} | ||
<item> | ||
<title>{{ project_name }} {{ release.version }}</title> | ||
<link>{{ request.route_url('packaging.release', name=release.project.normalized_name, version=release.version) }}</link> | ||
<description>{{ release.summary }}</description> | ||
<pubDate>{{ release.created|format_rfc822_datetime() }}</pubDate> | ||
</item> | ||
{% endfor %} | ||
{% endblock %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we made the necessary changes to get a
project
via theProjectFactory
, we could just pass theproject
variable to the template here, and useproject.name
andproject.releases
(which is ordered by creation date) directly in the template.