Skip to content
This repository was archived by the owner on Apr 4, 2024. It is now read-only.

Fixed #24 invalid enter_room and leave_room #25

Merged
merged 2 commits into from
Oct 30, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CONTRIBUTORS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@

* [Matthew D. Scholefield](https://github.com/MatthewScholefield) - Added cors allowed origins for AsyncServer [#7](https://github.com/pyropy/fastapi-socketio/pull/7)
* [Aaron Tolman](https://github.com/tolmanam) - Reported issue with broken pip download [#5](https://github.com/pyropy/fastapi-socketio/issues/5)
* [Khiem Doan](https://github.com/khiemdoan) - Helped with cleaning up old unused dependencies[#5](https://github.com/pyropy/fastapi-socketio/issues/15)
* [Khiem Doan](https://github.com/khiemdoan) - Helped with cleaning up old unused dependencies[#5](https://github.com/pyropy/fastapi-socketio/issues/15)
* [Artem Kolomatskiy](https://github.com/Roxe322) - Fixed invalid usage of enter_room and leave_room[#24](https://github.com/pyropy/fastapi-socketio/issues/24)
12 changes: 6 additions & 6 deletions fastapi_socketio/socket_manager.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from typing import Union

import socketio
from typing import Optional, Union
from fastapi import FastAPI

class SocketManager:
Expand Down Expand Up @@ -89,10 +90,9 @@ def sleep(self):
return self._sio.sleep

@property
def enter_room(self, sid: str, room: str, namespace: Optional[str] = None):
return self._sio.enter_room(sid, room, namespace)
def enter_room(self):
return self._sio.enter_room

@property
def leave_room(self, sid: str, room: str, namespace: Optional[str] = None):
return self._sio.leave_room(sid, room, namespace)

def leave_room(self):
return self._sio.leave_room