Skip to content
This repository was archived by the owner on Apr 4, 2024. It is now read-only.

Use cors_allowed_origins in AsyncServer #7

Merged
merged 1 commit into from
Nov 25, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions fastapi_socketio/socket_manager.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import socketio
from typing import Union
from fastapi import FastAPI


Expand All @@ -21,10 +22,10 @@ def __init__(
app: FastAPI,
mount_location: str = "/ws",
socketio_path: str = "socket.io",
cors_allowed_origins: list = [],
cors_allowed_origins: Union[str, list] = '*',
) -> None:
# TODO: Change Cors policy based on fastapi cors Middleware
self._sio = socketio.AsyncServer(async_mode="asgi", cors_allowed_origins="*")
self._sio = socketio.AsyncServer(async_mode="asgi", cors_allowed_origins=cors_allowed_origins)
self._app = socketio.ASGIApp(
socketio_server=self._sio, socketio_path=socketio_path
)
Expand Down