Skip to content

Reduce number of locations where warnings are raised. #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2022
Merged

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented May 22, 2022

Closes #270.

@tobiasraabe tobiasraabe added this to the v0.2.3 milestone May 22, 2022
@codecov
Copy link

codecov bot commented May 22, 2022

Codecov Report

Merging #278 (2a09621) into main (bec6d2e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #278   +/-   ##
=======================================
  Coverage   96.60%   96.61%           
=======================================
  Files          90       90           
  Lines        7605     7623   +18     
=======================================
+ Hits         7347     7365   +18     
  Misses        258      258           
Flag Coverage Δ
end_to_end 82.48% <52.63%> (-0.08%) ⬇️
integration 41.23% <10.52%> (-0.08%) ⬇️
unit 69.44% <100.00%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/_pytask/warnings.py 83.00% <100.00%> (+1.18%) ⬆️
tests/test_warnings.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bec6d2e...2a09621. Read the comment docs.

@tobiasraabe tobiasraabe merged commit a8d9e8a into main May 22, 2022
@tobiasraabe tobiasraabe deleted the fix-270 branch May 22, 2022 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Count warnings of the same type in the same locations instead of printing the location multiple times.
1 participant