Skip to content

Parse dependencies from all args if depends_on is not used. #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 5, 2023

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented May 28, 2023

Closes #338.

Changes

  • If depends_on is used, handle everything as before.
  • If depends_on is not used, parse dependencies from all args except produces.
  • Adds PythonNode.
  • If you use @pytask.mark.depends_on or @pytask.mark.produces, the task function must have the associated argument.
  • PathNodes can only be created from strings when used in @pytask.mark.depends_on.

Questions

  • Make pytask collect compliant with other node types.
  • Do we want to provide default hashers for dicts, lists?

@tobiasraabe tobiasraabe added this to the v0.4.0 milestone May 28, 2023
@tobiasraabe tobiasraabe changed the base branch from main to v4 June 11, 2023 16:55
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

❗ No coverage uploaded for pull request base (v4@a99e54a). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 39cdfb5 differs from pull request most recent head 953a712. Consider uploading reports for the commit 953a712 to get more accurate results

@@          Coverage Diff          @@
##             v4     #384   +/-   ##
=====================================
  Coverage      ?   96.05%           
=====================================
  Files         ?       90           
  Lines         ?     7725           
  Branches      ?        0           
=====================================
  Hits          ?     7420           
  Misses        ?      305           
  Partials      ?        0           
Flag Coverage Δ
end_to_end 82.64% <0.00%> (?)
integration 39.97% <0.00%> (?)
unit 67.23% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant