Skip to content

Remove .value from Node protocol. #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Conversation

tobiasraabe
Copy link
Member

  • Do not require .value for Node.
  • to changes.

Changes

Provide a description and/or bullet points to describe the changes in this PR.

Todo

  • Reference issues which can be closed due to this PR with "Closes #x".
  • Review whether the documentation needs to be updated.
  • Document PR in docs/changes.rst.

@tobiasraabe tobiasraabe added this to the v0.4.0 milestone Aug 29, 2023
@tobiasraabe tobiasraabe enabled auto-merge (squash) August 29, 2023 08:21
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #408 (6d1a59a) into main (449635e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 6d1a59a differs from pull request most recent head 33fac11. Consider uploading reports for the commit 33fac11 to get more accurate results

@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
- Coverage   95.66%   95.65%   -0.01%     
==========================================
  Files          94       94              
  Lines        8296     8293       -3     
==========================================
- Hits         7936     7933       -3     
  Misses        360      360              
Flag Coverage Δ
end_to_end 82.97% <100.00%> (-0.01%) ⬇️
integration 39.56% <71.42%> (-0.03%) ⬇️
unit 65.98% <85.71%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/_pytask/node_protocols.py 100.00% <ø> (ø)
tests/test_collect_command.py 100.00% <ø> (ø)
src/_pytask/nodes.py 93.10% <100.00%> (-0.12%) ⬇️

@tobiasraabe tobiasraabe merged commit 477e49e into main Aug 29, 2023
@tobiasraabe tobiasraabe deleted the do-not-require-value-in-protocol branch August 29, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant