Skip to content

Allow to pass functions to PythonNode(hash=...). #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

tobiasraabe
Copy link
Member

Changes

Provide a description and/or bullet points to describe the changes in this PR.

Todo

  • Reference issues which can be closed due to this PR with "Closes #x".
  • Review whether the documentation needs to be updated.
  • Document PR in docs/changes.rst.

@tobiasraabe tobiasraabe added this to the v0.4.0 milestone Aug 29, 2023
@tobiasraabe tobiasraabe enabled auto-merge (squash) August 29, 2023 12:35
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #410 (b2ba9c1) into main (453faf0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head b2ba9c1 differs from pull request most recent head 647d412. Consider uploading reports for the commit 647d412 to get more accurate results

@@            Coverage Diff             @@
##             main     #410      +/-   ##
==========================================
+ Coverage   95.64%   95.66%   +0.01%     
==========================================
  Files          94       94              
  Lines        8294     8303       +9     
==========================================
+ Hits         7933     7943      +10     
+ Misses        361      360       -1     
Flag Coverage Δ
end_to_end 82.93% <60.00%> (-0.03%) ⬇️
integration 39.55% <50.00%> (+<0.01%) ⬆️
unit 66.06% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/_pytask/nodes.py 94.06% <100.00%> (+0.96%) ⬆️
tests/test_nodes.py 100.00% <100.00%> (ø)

@tobiasraabe tobiasraabe merged commit 4bd60bf into main Aug 29, 2023
@tobiasraabe tobiasraabe deleted the python-node-hash branch August 29, 2023 12:42
@tobiasraabe tobiasraabe mentioned this pull request Aug 29, 2023
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant