Skip to content

Tests don't fail anymore #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
a7p opened this issue Jun 1, 2016 · 4 comments
Closed

Tests don't fail anymore #26

a7p opened this issue Jun 1, 2016 · 4 comments

Comments

@a7p
Copy link
Contributor

a7p commented Jun 1, 2016

having a minimal:

from pytest import mark
@mark.xfail(reason="I need a failing 
def test_fail_please():
     assert False

@mark.xfail(reason="I'm testing for a pytest-asyncio-bug - if I don't fail something is broken.")
@mark.asyncio
def test_fail_async():
     assert False

test_fail_async fails as expected with asyncio==0.3.0, but succeeds with asyncio==0.4.0.

(running python3.5.1)

a7p added a commit to a7p/pytest-asyncio that referenced this issue Jun 1, 2016
@Tinche
Copy link
Member

Tinche commented Jun 1, 2016

Hi, thanks for reporting, it's a known issue: #25. Expect a new release later today :)

@a7p
Copy link
Contributor Author

a7p commented Jun 1, 2016

arg - the title did not make me look at the issue ;).

Tinche added a commit that referenced this issue Jun 1, 2016
adds a test to reproduce issue #26
@Tinche
Copy link
Member

Tinche commented Jun 1, 2016

Hi, I've just pushed 0.4.1 to PyPI. Can you confirm it fixes the issue for you?

@a7p
Copy link
Contributor Author

a7p commented Jun 2, 2016

thank you very much - it does.

@a7p a7p closed this as completed Jun 2, 2016
smagafurov pushed a commit to smagafurov/pytest-asyncio that referenced this issue Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants