No warning on skip in asyncio #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asyncio doesn't get the results of tasks that fail with exceptions that don't subclass `Exception` (like pytest's `Skipped`) in `run_until_complete`. This leads to asyncio logging noisily warning when pytest's skip functionality is mixed with this plugin. This fixes this error, and adds a test.
blueyed
approved these changes
Jul 2, 2019
Co-Authored-By: Daniel Hahler <[email protected]>
|
Should be good to go. |
asvetlov
requested changes
Jul 4, 2019
aecay
added a commit
to sky-uk/mite
that referenced
this pull request
Jul 9, 2019
changes: - introduce a new mite.utils.sleep function (so that tests donʼt sleep for a long time) - change the base class of HandledException to work around a bug in pytest-asyncio (pytest-dev/pytest-asyncio#126) - better async exception handling - fix event loop handling in mite_http - new mite.test module
aecay
added a commit
to sky-uk/mite
that referenced
this pull request
Jul 9, 2019
changes: - introduce a new mite.utils.sleep function (so that tests donʼt sleep for a long time) - change the base class of HandledException to work around a bug in pytest-asyncio (pytest-dev/pytest-asyncio#126) - better async exception handling - fix event loop handling in mite_http - new mite.test module
Co-Authored-By: Andrew Svetlov <[email protected]>
asvetlov
approved these changes
Jul 16, 2019
|
Can this be merged? |
|
I think yes but I have no commit privilegy to do it myself. |
|
cc @Tinche |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asyncio doesn't get the results of tasks that fail with exceptions that
don't subclass
Exception(like pytest'sSkipped) inrun_until_complete. This leads to asyncio logging noisily warning whenpytest's skip functionality is mixed with this plugin.
This fixes this error, and adds a test.
Fixes #123.