Skip to content

Next release #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 4, 2019
Merged

Next release #344

merged 3 commits into from
Oct 4, 2019

Conversation

ionelmc
Copy link
Member

@ionelmc ionelmc commented Sep 26, 2019

So the plan is to upload it on Monday. Comment if I got something wrong in the files.

After this release I guess we start cutting compatibility with old stuff and then we see about #337.

@nedbat, @graingert

@nedbat
Copy link
Collaborator

nedbat commented Sep 26, 2019

I would love to get #342 merged before that release.

@nedbat
Copy link
Collaborator

nedbat commented Sep 30, 2019

I am very close to merging #345, but I think I need to make a change in coverage.py first. Can we hold off a day or two?

@ionelmc
Copy link
Member Author

ionelmc commented Sep 30, 2019

We can do anything, that date ain't written in stone. But we can also do a 2.9.0 with just the context stuff - to not feel pressed to make a coveragepy release quickly. What will it be?

@nedbat
Copy link
Collaborator

nedbat commented Sep 30, 2019

I was going to change an API from using glob to using regex. But I can handwave over that. Let me write the docs, and then #345 will be ready to merge.

@nedbat
Copy link
Collaborator

nedbat commented Oct 2, 2019

I've changed my mind again. Go ahead and do this release without #345.

@nedbat
Copy link
Collaborator

nedbat commented Oct 2, 2019

Or wait a day or two for me. Your choice.

@nedbat
Copy link
Collaborator

nedbat commented Oct 3, 2019

#345 is ready to go. Please merge it and then release.

@ionelmc
Copy link
Member Author

ionelmc commented Oct 3, 2019

@nicoddemus any idea why I can't cancel appveyor builds on this project?

@ionelmc
Copy link
Member Author

ionelmc commented Oct 3, 2019

So it looks like this might be broken with the just-released xdist 0.30, ooof.

@blueyed
Copy link
Contributor

blueyed commented Oct 3, 2019

Looks like it might be only due to the header?

remains unmatched: '*- coverage: platform , python * -'

@ionelmc
Copy link
Member Author

ionelmc commented Oct 3, 2019

Workers don't appear to return coverage data. I suspect this is the cause https://github.com/pytest-dev/pytest-xdist/pull/448/files#r330989777

@ionelmc
Copy link
Member Author

ionelmc commented Oct 4, 2019

Mkay so it looks like pytest 5.x and xdist 0.30 break the non-collocated mode (xdist in popen/ssh mode). Pytest 4.6 or xdist 0.29 or earlier work fine.

Since no one complained yet about releasing delays I'll spend some time investigating this.

@ionelmc
Copy link
Member Author

ionelmc commented Oct 4, 2019

Actually screw it, I'll release it as is, 3.8 is broken as well, and previous pytest-cov release is even more broken.

@ionelmc ionelmc merged commit 9f227c2 into master Oct 4, 2019
@Zac-HD Zac-HD deleted the update-changelog branch December 11, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants