Replace deprecated addhooks call. #14
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failure in the CI seems unrelated to this change |
| @@ -58,4 +58,4 @@ def pytest_runtest_call(item): | |||
| def pytest_addhooks(pluginmanager): | |||
| """Register plugin hooks.""" | |||
| from pytest_factoryboy import hooks | |||
| pluginmanager.addhooks(hooks) | |||
| pluginmanager.add_hookspecs(hooks) | |||
There was a problem hiding this comment.
this will need a change to requirements pytest >= 2.8.0
and that version has a bug with xdist pytest-dev/pytest#1062
There was a problem hiding this comment.
You're right, I can update that too if you'd like. But there's no rush anymore, 2.8.1 should work.
I don't actually use factoryboy personally, I only put this up because it helped me triage that pytest bug.
|
It was also fixed in #19, thanks anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaks in pytest 2.8 due to a regression. See pytest-dev/pytest#1034