-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Config._checkversion checks installed pytest version #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Original comment by Ronny Pfannschmidt (BitBucket: RonnyPfannschmidt, GitHub: RonnyPfannschmidt): sounds like a different kind of bug, after a genscript-based pytest is loaded, |
Original comment by Ronny Pfannschmidt (BitBucket: RonnyPfannschmidt, GitHub: RonnyPfannschmidt): ok, after a bit of code-skimming, i think there is need to do a deeper review of pylib/pytest wrt use of apipkg and the genscript entrypoint, |
Originally reported by: Matt Davis (BitBucket: jiffyclub, GitHub: jiffyclub)
When setting minversion = X.X in a setup.cfg or similar the version checking does an absolute import of pytest and checks the version of that module.
With this being the case I can bundle py.test 2.2 with my package (using the --genscript file) and explicitly use that for running my tests, but if I have py.test 2.1 installed elsewhere on my system so that
import pytest
imports py.test 2.1, it will still fail the minversion test.It would be preferable for Config._checkversion to check the version of py.test that is actually running, and not the version returned by
import pytest
.The text was updated successfully, but these errors were encountered: