deprecated_call detects pending warnings again
#1081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`deprecated_call` now looks for PendingDeprecationWarnings, as it did previously but was broken by pytest-dev#897. Fixes pytest-dev#1037. Also added a test so this does not happen again.
`deprecated_call` used to accept any warning. As of pytest-dev#897, it is now specific to DeprecationWarnings, and another commit in this PR extends this to PendingDeprecationWarnings. This commit makes sure this stays the case.
hpk42
added a commit
that referenced
this pull request
Sep 28, 2015
`deprecated_call` detects pending warnings again
mark-adams
added a commit
to mark-adams/pyjwt
that referenced
this pull request
Oct 9, 2015
…ation warnings This was fixed in pytest-dev/pytest#1081 but is not released yet.
mark-adams
added a commit
to mark-adams/pyjwt
that referenced
this pull request
Oct 9, 2015
…ation warnings This was fixed in pytest-dev/pytest#1081 but is not released yet.
rylanhall33
added a commit
to rylanhall33/pyjwt
that referenced
this pull request
Jun 15, 2022
…ation warnings This was fixed in pytest-dev/pytest#1081 but is not released yet.
xmas7
pushed a commit
to RubyOnWorld/pyjwt
that referenced
this pull request
Sep 6, 2022
…ation warnings This was fixed in pytest-dev/pytest#1081 but is not released yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit ensures
deprecated_callnow looks for PendingDeprecationWarnings, as it did previously but was broken by #897. Fixes #1037. Also added a test so this does not happen again.I realized that before 2.8.0,
deprecated_callwould be fine with any warning being raised, not just a DeprecationWarning or PendingDeprecationWarning. The second commit ensures that other warnings do not suffice.