Skip to content

Add more resources and studies to flaky tests page in docs #13250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 1, 2025

Conversation

gewenyu99
Copy link
Contributor

Hi there.

I found the flaky tests page in the Pytest docs, and the studies/resources here were helpful, some of which I've not seen.

I wanted to return the favor and share some newer resources and studies that I've found useful while building my solutions.

@gewenyu99
Copy link
Contributor Author

Two questions:

  • for a PR like this, should I create and issue first and attach change logs?
  • I have some other studies that aren't publically available in PDF form (as in you need access from the journal publishers), would it be helpful to include them still? Some of them are quite good.

@nicoddemus
Copy link
Member

nicoddemus commented Feb 24, 2025

Thanks! 🙇

for a PR like this, should I create and issue first and attach change logs?

No need, but if you want, you can add a 13250.doc.rst file to CHANGELOG -- but small changes like this are probably not worth it.

I have some other studies that aren't publically available in PDF form (as in you need access from the journal publishers), would it be helpful to include them still? Some of them are quite good.

I think it is fine, thanks! Perhaps add a *(requires account at X)* or *(paid access)* (something like that) to the end to warn readers.

@gewenyu99 gewenyu99 requested a review from nicoddemus February 27, 2025 20:15
@gewenyu99
Copy link
Contributor Author

Hey, I've fixed up the duplicate link. I can access the Divaportal link fine; it might be a case where the paper restricts access by region, but I can't seem to pinpoint it.

@webknjaz webknjaz added the skip news used on prs to opt out of the changelog requirement label Feb 28, 2025
@webknjaz
Copy link
Member

@nicoddemus as many of these are whitepapers, would it make sense to integrate sphinxcontrib-bibtex?

@webknjaz webknjaz added the type: docs documentation improvement, missing or needing clarification label Feb 28, 2025
@nicoddemus
Copy link
Member

@nicoddemus as many of these are whitepapers, would it make sense to integrate sphinxcontrib-bibtex?

Sounds interesting for sure, but that would better be done in a separate PR I think. 👍

Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gewenyu99!

@nicoddemus nicoddemus added the backport 8.3.x apply to PRs at any point; backports the changes to the 8.3.x branch label Mar 1, 2025
@nicoddemus nicoddemus enabled auto-merge (squash) March 1, 2025 13:35
@nicoddemus nicoddemus merged commit 9f3c4d1 into pytest-dev:main Mar 1, 2025
28 checks passed
Copy link

patchback bot commented Mar 1, 2025

Backport to 8.3.x: 💚 backport PR created

✅ Backport PR branch: patchback/backports/8.3.x/9f3c4d11d9b162d0926e9a3ae57ec6f262362d73/pr-13250

Backported as #13259

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 1, 2025
---
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: Bruno Oliveira <[email protected]>

(cherry picked from commit 9f3c4d1)
nicoddemus pushed a commit that referenced this pull request Mar 1, 2025
…13259)

---
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: Bruno Oliveira <[email protected]>

(cherry picked from commit 9f3c4d1)

Co-authored-by: Vincent (Wen Yu) Ge <[email protected]>
@gewenyu99
Copy link
Contributor Author

Great, thanks for reviewing these. @nicoddemus and @webknjaz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 8.3.x apply to PRs at any point; backports the changes to the 8.3.x branch skip news used on prs to opt out of the changelog requirement type: docs documentation improvement, missing or needing clarification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants