issue469: junit parsing nodeid, add method test #1432
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional test as recommend before #1431 was merged :-)
Also added name to the changelog entry. And repositioned the rst link definition.
While I'm here couple comments on the changelog:
we're in risk of the(#469_)
numbers referencing both issues and pull requests clashing (both are up to around 1400 now). Obviously all links are explicitly defined, but could be confusing. rst-lint will error on duplicate definitions, but if someone forgets the 2nd definition, it would silently reference the first. Maybe reference PRs as(PR#469_)
and keep(#469_)
for issues?