Fix pytest.mark.skip mark when used in strict mode

[pquentin]

This targets master since it's a bug, but no CHANGELOG or AUTHORS since I'm only sending a xfail test. Should I still do something to one of those files?

[The-Compiler]

Thanks! Is there an issue for the bug open already?

Feel free to add yourself to authors regardless, a testcase is already half the fix 😉 (or don't, if you prefer not to).

[pquentin]

@The-Compiler thanks for the reactivity! I didn't find an issue, no. Should I open one?

[RonnyPfannschmidt]

pytest/_pytest/skipping.py

Line 33 in cbb5d48

config.addinivalue_line("markers",

needs another line to fix it - feel free to add it and put yourself in the changelog/authors file

happy hacking

[The-Compiler]

Ah, I was searching where they were defined, but @RonnyPfannschmidt was faster 😆

[nicoddemus]

Oops, I just noticed that xfail description in the same place is lacking docs for the new strict parameter.

@pquentin while you're at it, would you mind adding that parameter to xfail's docs as well? 😁

[pquentin]

@nicoddemus Sure, but I'll do it in a different PR to avoid confusion because it's a different strict parameter.

[nicoddemus]

I think the changes are related (updating the list of markers), but do as you prefer, sure!

Thanks! 😁

[pquentin]

@nicoddemus It's in the PR, but in a different commit.

You guys are amazing, thanks for commenting on this PR this quickly. I think it's ready for review (if CI passes).

[The-Compiler]

This is confusing, as it's only a doc fix, right? IMHO, I don't think this should be mentioned in the changelog at all.

[pquentin]

@The-Compiler Thanks. I removed the entry from the changelog and mentioned "doc" in the commit.

[pquentin]

The travis issue appears to be coverall's fault? https://travis-ci.org/pytest-dev/pytest/jobs/117691035

[The-Compiler]

Seems like: lemurheavy/coveralls-public#741

[RonnyPfannschmidt]

the rest looks good, i wonder if we should allow failures from coveralls

[RonnyPfannschmidt]

thanks for the work - well done :)

[pquentin]

The comprehensive test suite, the well-written code and the help from all three of you made this easy Thanks!

[coveralls]

Coverage increased (+0.0009%) to 92.257% when pulling 4559c11 on pquentin:master into 890c2fa on pytest-dev:master.