Fix a small issue about shlex.split not working well with win32 path

[afterhill]

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

• Target: Fix a win32 path issue, so I target master branch
• Tests: added
• Add yourself to AUTHORS (done)
• Add a new entry to the CHANGELOG (done)

Issue description:

Under win32 machine:

import pytest
get_ini_path = from_some_other_func
pytest.main("-c " + get_ini_path)

Look at the shlex.split signature:

shlex.split(str, posix=True)

the posix default value is True, once I passed a win32 path (e.x. D:\tests\pytest.ini) into shlex.split, it will output as Dtestspytest.ini. This PR will check the platform firstly before applying the win32 path into shlex.split.

[RonnyPfannschmidt]

how about just using shlex.split(args, posix=sys.platform == "win32")

[nicoddemus]

@RonnyPfannschmidt of course meant shlex.split(args, posix=sys.platform != 'win32'). 😉

[RonnyPfannschmidt]

good find,

for platform-quicks, tests are necessary, since its easy to miss reasons and implementation details
i'm also wondering if we could perhaps just use https://docs.python.org/2/library/shlex.html#shlex.shlex.whitespace_split

@nicoddemus please have a quick look

[nicoddemus]

@RonnyPfannschmidt sure, will do it on my lunch break later. 😁

[nicoddemus]

Looks good, except for lack of tests as @RonnyPfannschmidt mentioned. 😁

Thanks @MengJueM for the work!

[afterhill]

@RonnyPfannschmidt @nicoddemus One test is added.

[nicoddemus]

@MengJueM while the change is small, I think it is worth a mention in the changelog... I'm sure more people has been bitten by it, so a changelog entry will help raise awareness that this has been fixed. 😁

Thanks again for the work!

[afterhill]

@nicoddemus Changelog is added. I was getting impressed about the good quality and coverage when I started to review the testing cases of pytest. Thanks for your guys maintaining such a perfect project. Pytest is amazing.

[nicoddemus]

Thanks, we do appreciate your compliment and the effort on the PR! 😄