Skip to content

Cleanups for #1763 #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2016
Merged

Cleanups for #1763 #1765

merged 1 commit into from
Jul 25, 2016

Conversation

The-Compiler
Copy link
Member

Consider this my after-the-fact review for #1763 😉

cc @tomviner @JonathonSonesen

@RonnyPfannschmidt
Copy link
Member

looks good to me, since the ci didnt run on it please merge after a local test

@coveralls
Copy link

coveralls commented Jul 25, 2016

Coverage Status

Coverage remained the same at 92.293% when pulling 7d561f0 on The-Compiler:1763-cleanup into c9a2e61 on pytest-dev:master.

@@ -96,7 +96,7 @@ def wrap_session(config, doit):
excinfo.value, pytest.exit.Exception):
excinfo = _pytest._code.ExceptionInfo()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isnt this one double ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, yeah, probably... Maybe @tomviner can shed some light on it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, my bad, that's a left from over from a different approach. Please delete that line.

@tomviner
Copy link
Contributor

@The-Compiler thanks for the cleanup here. Much appreciated.

@The-Compiler
Copy link
Member Author

The double line is gone now.

@coveralls
Copy link

coveralls commented Jul 25, 2016

Coverage Status

Coverage decreased (-0.0009%) to 92.292% when pulling a309a57 on The-Compiler:1763-cleanup into c9a2e61 on pytest-dev:master.

@tomviner
Copy link
Contributor

👍

@RonnyPfannschmidt RonnyPfannschmidt merged commit d37af20 into pytest-dev:master Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants