-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Cleanups for #1763 #1765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanups for #1763 #1765
Conversation
looks good to me, since the ci didnt run on it please merge after a local test |
@@ -96,7 +96,7 @@ def wrap_session(config, doit): | |||
excinfo.value, pytest.exit.Exception): | |||
excinfo = _pytest._code.ExceptionInfo() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isnt this one double ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, yeah, probably... Maybe @tomviner can shed some light on it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, my bad, that's a left from over from a different approach. Please delete that line.
@The-Compiler thanks for the cleanup here. Much appreciated. |
The double line is gone now. |
👍 |
Consider this my after-the-fact review for #1763 😉
cc @tomviner @JonathonSonesen