Skip to content

Only execute "coveralls" toxenv once on AppVeyor #2084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2016

Conversation

nicoddemus
Copy link
Member

Just noticed that the "coveralls" env was being execute after each env, making builds for pytest's own branches take unnecessarily long.

This was introduced by mistake in #2056

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.818% when pulling 6a98faf on nicoddemus:fix-coveralls-appveyor into 38f7562 on pytest-dev:master.

@nicoddemus nicoddemus changed the title Only execute "coveralls" toxenv on master once on AppVeyor Only execute "coveralls" toxenv once on AppVeyor Nov 24, 2016
@nicoddemus nicoddemus force-pushed the fix-coveralls-appveyor branch 2 times, most recently from 873f690 to 9d4a2f1 Compare November 24, 2016 21:26
Just noticed that the "coveralls" env was being execute after each env.

This was introduced by mistake in pytest-dev#2056
@nicoddemus nicoddemus force-pushed the fix-coveralls-appveyor branch from 9d4a2f1 to 8763590 Compare November 24, 2016 21:27
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.819% when pulling 9d4a2f1 on nicoddemus:fix-coveralls-appveyor into b3efd9a on pytest-dev:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.819% when pulling 8763590 on nicoddemus:fix-coveralls-appveyor into b3efd9a on pytest-dev:master.

@nicoddemus
Copy link
Member Author

I'm going ahead and merge this as it only affects AppVeyor runs and fixes a bug introduced by me. 😁

@nicoddemus nicoddemus merged commit 33796c8 into pytest-dev:master Nov 24, 2016
@nicoddemus nicoddemus deleted the fix-coveralls-appveyor branch November 24, 2016 21:43
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.819% when pulling 8763590 on nicoddemus:fix-coveralls-appveyor into b3efd9a on pytest-dev:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants