remove the MARK_INFO_ATTRIBUTE warning until we can fix internal usage

[RonnyPfannschmidt]

fixes #2573

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

• Add a new news fragment into the changelog folder
  • name it $issue_id.$type for example (588.bug)
  • if you don't have an issue_id change it to the pr id after creating the pr
  • ensure type is one of removal, feature, bugfix, vendor, doc or trivial
  • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."
• Target: for bugfix, vendor, doc or trivial fixes, target master; for removals or features target features;
• Make sure to include reasonable tests for your change if necessary

Unless your change is a trivial or a documentation fix (e.g., a typo or reword of a small section) please:

• Add yourself to AUTHORS;

[The-Compiler]

Not sure if it makes sense to have a changelog for something which was never released - but LGTM otherwise, the features branch seems to work fine with qutebrowser's testsuite now!

[coveralls]

Coverage decreased (-0.02%) to 91.88% when pulling 8df2635 on RonnyPfannschmidt:fix-2573 into 1485a3a on pytest-dev:features.

[The-Compiler]

Looks like flake8 is failing because there's now an unused MARK_INFO_ATTRIBUTE attribute.

[coveralls]

Coverage decreased (-0.02%) to 91.88% when pulling 8df2635 on RonnyPfannschmidt:fix-2573 into 1485a3a on pytest-dev:features.

[nicoddemus]

I agree we don't need the changelog. 👍

[The-Compiler]

btw, while we're at it, can we please add a test which fails on features and passes with this PR, so we can make sure we catch this when reintroducing the warning?

[nicoddemus]

while we're at it, can we please add a test which fails on features and passes with this PR

Definitely 👍

[nicoddemus]

What if we turn all warnings into errors, explicitly ignoring those we have no control over (from external libraries for example) and overwrite specific rules in tests which expect the warnings to be displayed? I think this would prevent this error and others from creeping at us in the future.

[The-Compiler]

So essentially running pytest's testsuite with --pythonwarnings error then? Sounds good to me, but probably is quite a bit of work.

[nicoddemus]

Sounds good to me, but probably is quite a bit of work.

Possibly. What do you think @RonnyPfannschmidt? I guess you are short on time and won't be able to do this in this PR right? If that's the case, I propose to create a separate issue and tackle this soon®. I might have some time later this week, but if somebody else can get to this before then the better.

[coveralls]

Coverage decreased (-0.02%) to 91.88% when pulling e8ccb71 on RonnyPfannschmidt:fix-2573 into 1485a3a on pytest-dev:features.

[coveralls]

Coverage decreased (-0.02%) to 91.88% when pulling 3dd31bb on RonnyPfannschmidt:fix-2573 into 1485a3a on pytest-dev:features.

[nicoddemus]

Thanks @RonnyPfannschmidt, only thing left is removing the news file. Want me to do it before merging?

[coveralls]

Coverage decreased (-0.02%) to 91.88% when pulling 62556ba on RonnyPfannschmidt:fix-2573 into 1485a3a on pytest-dev:features.

[nicoddemus]

Thanks @RonnyPfannschmidt!