Skip to content

Preparing release version 3.7.4 #3906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2018
Merged

Preparing release version 3.7.4 #3906

merged 1 commit into from
Aug 29, 2018

Conversation

asottile
Copy link
Member

No description provided.

@asottile asottile requested a review from nicoddemus August 29, 2018 15:59
@nicoddemus
Copy link
Member

Thanks @asottile!

@asottile
Copy link
Member Author

@nicoddemus the steps don't indicate when I should merge this PR / when I should create the tag (I'll fix them!) -- at what point should those things happen?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 92.238% when pulling aea962d on asottile:release-3.7.4 into 4345efa on pytest-dev:master.

@nicoddemus
Copy link
Member

Ahh right.

After all tests have passed, push the tag to upstream with the PR still open. After the Travis job finishes and the deploy is complete, we merge the PR and make the announcements.

We can update the HOWTORELEASE after 3.7.4 is out to avoid having to wait for the CI all over again.

@asottile
Copy link
Member Author

also I think I need to run git tag 3.7.4 myself as well? I can add that to the steps as well

@nicoddemus
Copy link
Member

also I think I need to run git tag 3.7.4 myself as well? I can add that to the steps as well

Yes, that is not very explicit there. Thanks!

@asottile
Copy link
Member Author

@nicoddemus lol, do you wait for appveyor?

@nicoddemus
Copy link
Member

@nicoddemus lol, do you wait for appveyor?

Yep 😬 Let me check the queue and see if there are jobs scheduled that can be skipped...

@nicoddemus
Copy link
Member

Oh this is running already... just need to wait a bit then.

@wimglenn
Copy link
Member

appveyor

@asottile
Copy link
Member Author

I once had an appveyor build finish before travis-ci -- I restarted it since I assumed something was wrong

@blueyed
Copy link
Contributor

blueyed commented Aug 29, 2018

Maybe we should trim down the matrix for AV?

@asottile
Copy link
Member Author

could also crowdfund, their paid plan has better parallelism iirc

@RonnyPfannschmidt
Copy link
Member

hmm, neo would disapprove of a low res matrix

@codecov
Copy link

codecov bot commented Aug 29, 2018

Codecov Report

Merging #3906 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3906      +/-   ##
==========================================
+ Coverage   92.18%   92.23%   +0.04%     
==========================================
  Files          52       52              
  Lines       10009    10009              
==========================================
+ Hits         9227     9232       +5     
+ Misses        782      777       -5
Impacted Files Coverage Δ
src/_pytest/terminal.py 94.23% <0%> (+0.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4345efa...aea962d. Read the comment docs.

@nicoddemus
Copy link
Member

🎉

@asottile
Copy link
Member Author

tag is up! now more waiting :loading:

@nicoddemus
Copy link
Member

Just realized that we can configure Travis to skip the stages and go directly to deploy when it is building a tag... what do you guys think about that?

@asottile asottile merged commit d76fb83 into pytest-dev:master Aug 29, 2018
@asottile asottile deleted the release-3.7.4 branch August 29, 2018 20:03
@nicoddemus
Copy link
Member

Awesome, thanks @asottile!

@asottile
Copy link
Member Author

Your message has been rejected, probably because you are not
subscribed to the mailing list and the list's policy is to prohibit
non-members from posting to it.

awkward, I'll subscribe and send that out in a bit!

@nicoddemus
Copy link
Member

hehehe. Don't forget the tweet as well! 👍

@asottile
Copy link
Member Author

ok I think I did all the things now, or at least it hasn't sent me another bounce email 🎉

@blueyed
Copy link
Contributor

blueyed commented Aug 29, 2018

Thanks, @asottile !

Just realized that we can configure Travis to skip the stages and go directly to deploy when it is building a tag... what do you guys think about that?

👍

Just did this for pytest-django: pytest-dev/pytest-django@b1f1b26

I think it should run one test job before though.

@nicoddemus
Copy link
Member

nicoddemus commented Aug 29, 2018

How about skipping the test staging and only run baseline and deploy when in a tag?

@blueyed
Copy link
Contributor

blueyed commented Aug 29, 2018

Sounds good!

nicoddemus added a commit to nicoddemus/pytest that referenced this pull request Aug 29, 2018
Given that our guidelines demand that the CI have already passed, it seems
wasteful to run all those jobs again for the exact same commit.

As discussed in pytest-dev#3906 (comment),
this will skip the "test" stage when building a tag for deployment.
@nicoddemus
Copy link
Member

OK, cool: #3908. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants