-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Preparing release version 3.7.4 #3906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @asottile! |
@nicoddemus the steps don't indicate when I should merge this PR / when I should create the tag (I'll fix them!) -- at what point should those things happen? |
Ahh right. After all tests have passed, push the tag to We can update the HOWTORELEASE after |
also I think I need to run |
Yes, that is not very explicit there. Thanks! |
@nicoddemus lol, do you wait for appveyor? |
Yep 😬 Let me check the queue and see if there are jobs scheduled that can be skipped... |
Oh this is running already... just need to wait a bit then. |
I once had an appveyor build finish before travis-ci -- I restarted it since I assumed something was wrong |
Maybe we should trim down the matrix for AV? |
could also crowdfund, their paid plan has better parallelism iirc |
hmm, neo would disapprove of a low res matrix |
Codecov Report
@@ Coverage Diff @@
## master #3906 +/- ##
==========================================
+ Coverage 92.18% 92.23% +0.04%
==========================================
Files 52 52
Lines 10009 10009
==========================================
+ Hits 9227 9232 +5
+ Misses 782 777 -5
Continue to review full report at Codecov.
|
🎉 |
tag is up! now more waiting :loading: |
Just realized that we can configure Travis to skip the stages and go directly to deploy when it is building a tag... what do you guys think about that? |
Awesome, thanks @asottile! |
awkward, I'll subscribe and send that out in a bit! |
hehehe. Don't forget the tweet as well! 👍 |
ok I think I did all the things now, or at least it hasn't sent me another bounce email 🎉 |
Thanks, @asottile !
👍 Just did this for pytest-django: pytest-dev/pytest-django@b1f1b26 I think it should run one test job before though. |
How about skipping the |
Sounds good! |
Given that our guidelines demand that the CI have already passed, it seems wasteful to run all those jobs again for the exact same commit. As discussed in pytest-dev#3906 (comment), this will skip the "test" stage when building a tag for deployment.
OK, cool: #3908. 👍 |
No description provided.