Skip to content

tests/CI: enable branch coverage #3920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2018
Merged

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Aug 31, 2018

No description provided.

@blueyed blueyed added the type: infrastructure improvement to development/releases/CI structure label Aug 31, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 94.068% when pulling cbbb36f on blueyed:branch into 019e33e on pytest-dev:master.

@codecov
Copy link

codecov bot commented Aug 31, 2018

Codecov Report

Merging #3920 into master will decrease coverage by 1.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3920      +/-   ##
==========================================
- Coverage   96.24%   94.99%   -1.25%     
==========================================
  Files         108      108              
  Lines       23353    23353              
  Branches        0     2324    +2324     
==========================================
- Hits        22475    22185     -290     
  Misses        878      878              
- Partials        0      290     +290
Flag Coverage Δ
#doctesting 28.57% <ø> (-3.3%) ⬇️
#nobyte 90% <ø> (-3.51%) ⬇️
#numpy 28.22% <ø> (-3.21%) ⬇️
#pexpect 47.86% <ø> (-5.72%) ⬇️
#pluggymaster 93.73% <ø> (-1.34%) ⬇️
#py27 93.03% <ø> (-1.59%) ⬇️
#py34 92.26% <ø> (-1.62%) ⬇️
#py35 92.27% <ø> (-1.62%) ⬇️
#py36 93.28% <ø> (-1.54%) ⬇️
#py37 92.44% <ø> (-1.62%) ⬇️
#trial 31.17% <ø> (-2.93%) ⬇️
#xdist 93.21% <ø> (-1.43%) ⬇️
Impacted Files Coverage Δ
testing/freeze/runtests_script.py 0% <0%> (-25%) ⬇️
testing/freeze/tox_run.py 0% <0%> (-14.29%) ⬇️
testing/freeze/create_executable.py 0% <0%> (-12.5%) ⬇️
src/_pytest/assertion/__init__.py 86.36% <0%> (-10.61%) ⬇️
testing/test_modimport.py 80% <0%> (-10%) ⬇️
testing/test_argcomplete.py 65.62% <0%> (-7.82%) ⬇️
src/_pytest/_code/_py2traceback.py 85.71% <0%> (-7.15%) ⬇️
src/_pytest/assertion/truncate.py 92.15% <0%> (-5.89%) ⬇️
src/_pytest/config/argparsing.py 87.78% <0%> (-5.89%) ⬇️
src/_pytest/_argcomplete.py 74.28% <0%> (-5.72%) ⬇️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 019e33e...cbbb36f. Read the comment docs.

@nicoddemus
Copy link
Member

Not sure why the coverage has dropped...?

Also I noticed that codecov reported its findings 3 hours after Travis finished, but coveralls was much faster, taking only a few minutes. Is this common or a fluke?

@blueyed
Copy link
Contributor Author

blueyed commented Sep 1, 2018

Not sure why the coverage has dropped...?

Expected, since typically not all branches are covered.

But no idea why it increased (slightly) on coveralls?!
I'd say we should get rid of it.

codecov reported its findings 3 hours after Travis finished

They had DB issues yesterdays, should be faster typically.

@blueyed
Copy link
Contributor Author

blueyed commented Sep 1, 2018

Found this: lemurheavy/coveralls-public#31 - should be reported, but maybe not for Python?!
Codecov appears to still be swamped.

@nicoddemus
Copy link
Member

They had DB issues yesterdays, should be faster typically.

Oh OK, thanks.

Codecov appears to still be swamped.

I did notice in another PR today that the comment from codecov was posted right after the build finished, so it seems they are back to normal. 👍

I get we can merge this as is then?

@blueyed blueyed merged commit f3b9b21 into pytest-dev:master Sep 1, 2018
@blueyed
Copy link
Contributor Author

blueyed commented Sep 1, 2018

Yes!

@blueyed blueyed deleted the branch branch September 1, 2018 14:52
@blueyed blueyed restored the branch branch September 11, 2018 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: infrastructure improvement to development/releases/CI structure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants