Replace internal config._origargs with invocation_params.args #5644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
commented
Jul 23, 2019
| @@ -915,7 +915,7 @@ def parse(self, args, addopts=True): | |||
| assert not hasattr( | |||
| self, "args" | |||
| ), "can only parse cmdline args at most once per Config object" | |||
| self._origargs = args | |||
| assert self.invocation_params.args == args | |||
There was a problem hiding this comment.
Just for testing / ensuring - can be removed, and/or improved (msg).
There was a problem hiding this comment.
@RonnyPfannschmidt / @nicoddemus
What about this?
There was a problem hiding this comment.
hmm, that one seems ok to me
There was a problem hiding this comment.
Agreed, nothing fishy at first glance.
Codecov Report
@@ Coverage Diff @@
## features #5644 +/- ##
============================================
+ Coverage 94.78% 94.84% +0.06%
============================================
Files 117 117
Lines 25726 25726
Branches 2490 2490
============================================
+ Hits 24385 24401 +16
+ Misses 1021 1009 -12
+ Partials 320 316 -4
Continue to review full report at Codecov.
|
RonnyPfannschmidt
approved these changes
Jul 23, 2019
nicoddemus
approved these changes
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in #5564.