Skip to content

remove myself from the list of coc handlers #6857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2020

Conversation

RonnyPfannschmidt
Copy link
Member

as previously declared

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😞

@nicoddemus nicoddemus merged commit a5a8d53 into master Mar 3, 2020
@nicoddemus nicoddemus deleted the RonnyPfannschmidt-drop-coc-role branch March 3, 2020 22:09
@blueyed
Copy link
Contributor

blueyed commented Mar 8, 2020

as previously declared

This was not declared in public, was it? If so, a reference would have been good.

In either case a reference in the commit message would have been useful for history.
Currently not even the (IMHO) non-saying "as previously declared." is in the history.

(this is a suggestion from me looking at pytest's history recently, where you "only" have the commit messages/subjects)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants