Skip to content

Put smoke test deps in requirements.txt for Dependabot #7806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 10, 2020
Merged

Put smoke test deps in requirements.txt for Dependabot #7806

merged 3 commits into from
Oct 10, 2020

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Sep 27, 2020

Here's an idea.

This moves the smoke test deps from #7721 into a requirements.txt so they can pinned.

Then, https://dependabot.com can be added to monitor this new requirements.txt and send a new PR when there's a new plugin release. Add /testing/plugins_integration as the Directory:

That means we get a trigger when new plugins are released, which increases confidence that current master works with each plugin.

For example, see hugovk#6 and hugovk#7 on a similar branch on my fork.

Upsides:

  • Triggers a build on plugin releases
  • Always smoke test latest plugin version (as before)

Downsides:

  • More PRs.
    • If they're too frequent, the update schedule could be changed from live to daily, weekly or monthly.
    • It's also possible to set them to merge automatically once status checks pass.

I've left anyio at the non-latest version, to allow a test bump from 2.0.0 to 2.0.2.

Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd go for daily + automerge, but let's try it out and see what happens 🚀

@bluetech
Copy link
Member

bluetech commented Oct 6, 2020

Thanks @hugovk, this seems like a good way to keep the plugin smoketest fresh.

My preference is for a monthly update and without automerge (at least for start). I think daily would become annoying...

I believe dependabot is already configured for this repo, so we'd just need a suitable dependabot.yml file. Can you add one to this PR?

@hugovk
Copy link
Member Author

hugovk commented Oct 6, 2020

I've added a file for this exported config:

For info, the export said:

Dependabot is moving natively into GitHub, and we need a quick update from you to finish the move! Click "Create pull request" to open a pull request on pytest with a new config file. When you merge the pull request, we'll swap outdependabot-preview for a new dependabot app, and you'll be all set.

The pull request moves the UI configuration to a config file in.github/dependabot.yml. The config file uses the new syntax:

...

Your account is using automerging. There is no automerging support in GitHub-native Dependabot, so these settings will not be added to the new config file. Several 3rd-party GitHub Actions and bots can replicate the automerge feature.

Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's leave this up for a few days to let others a chance to chime in, then merge.

@nicoddemus
Copy link
Member

Great idea, thanks @hugovk!

I'd go for daily + automerge
My preference is for a monthly update

How about we compromise and have it once a week? Doesn't seem like this would be much overhead.

Regardless, 👍 from me!

@bluetech bluetech merged commit 3059caf into pytest-dev:master Oct 10, 2020
@hugovk hugovk deleted the smoketest-dependabot2 branch October 10, 2020 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants