Add file and line attributes to junit-xml output.

[kevincox]

This adds the file and lineno attributes to the junit-xml output
which can be used by tooling to identify where tests come from. This can be
used for many things such as IDEs jumping to failures and test
runners evenly balancing tests among multiple executors.

[nicoddemus]

Hey @kevincox, thanks for the PR.

Some questions:

1. Are those attributes part of a standard for JUnit xml schema? I did a quick googling and doesn't seem to exist a de-facto standard, but the ones I found (1, 2, 3) did not contain either file or lineno explicit attributes of the testcase tag...
2. Does the XML file generated by the PR work in Jenkins/other CI servers?
3. Can you give an example of tools know which make use of those attributes?

Cheers,

[kevincox]

I don't know if there is a "standard". I looked around and couldn't find anything except for a couple of random XML schemas (as you linked).

RSpec JUnit Formatter has file.

CircleCI uses these for [automatic balancing]. They also maintain their own formatter that provides this info for minitest (https://github.com/circleci/minitest-ci/blob/master/lib/minitest/ci.rb)

I haven't tested on Jenkins but since RSpeck JUnit formatter is designed for Jenkins I would imagine it does. And the point of XML is to be extensible. However if someone could give that a test it would be awesome, I don't have any Jenkins available.

[kevincox]

I fixed the tests on windows. I'll rebase it into one commit when I get home.

[nicoddemus]

@kevincox I did a quick test in a Jenkins instance using your branch, this was the file generated:

<?xml version="1.0" encoding="utf-8"?><testsuite errors="0" failures="0" name="pytest" skips="0" tests="1" time="0.010"><testcase classname="test_foo" file="test_foo.py" lineno="2" name="test_foo" time="0.000999927520752"/></testsuite>

But the jobs unfortunately fails:

[xUnit] [ERROR] - The result file 'W:\workspace\job1\foo-bar.xml' for the metric 'JUnit' is not valid. The result file has been skipped.

So it seems that unfortunately Jenkins has a strict schema checking regarding this... 😞

[kevincox]

I have updated the PR to use the line attribute instead because that appears to be Jenkins approved.

[nicoddemus]

Excellent!

Could you add the url of the junit-10.xsd file in the docstring of the junitxml.py file for future reference?
Also, could you please add yourself to AUTHORS and add an entry into the CHANGELOG?

I will test this myself tomorrow, and if nobody opposes this will merge it then. 😄

[kevincox]

Updated with the requested changes. Do they look good to you?

[nicoddemus]

They do, thanks!

[nicoddemus]

If you want, feel free to add a *Thanks to Kevin Cox for PR" like some of the other entries. 😉

[kevincox]

Aha I'm fine with this.

[nicoddemus]

Just tested and it works perfectly.

Thanks again for the PR! 😄