refactor(apps/price_pusher): Use viem instead of web3 for evm pusher #1829
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
ali-bahjati
force-pushed
the
price-pusher/use-viem-for-evm
branch
2 times, most recently
from
b8229e0 to
fe7f491
Compare
ali-bahjati
force-pushed
the
price-pusher/use-viem-for-evm
branch
4 times, most recently
from
cf04594 to
a090bef
Compare
ali-bahjati
force-pushed
the
price-pusher/use-viem-for-evm
branch
from
a090bef to
50fd666
Compare
ali-bahjati
force-pushed
the
price-pusher/use-viem-for-evm
branch
from
50fd666 to
265dc31
Compare
ali-bahjati
force-pushed
the
price-pusher/use-viem-for-evm
branch
from
265dc31 to
110a618
Compare
| let gasPrice = | ||
| Number(await this.customGasStation?.getCustomGasPrice()) || | ||
| Number(fees.gasPrice) || | ||
| Number(fees.maxFeePerGas); |
There was a problem hiding this comment.
is maxFeePerGas here potentially a very large number? wondering if there's a failure mode where we accidentally drain the wallet balance.
There was a problem hiding this comment.
I think this is equivalent to to the gas price itself. If we add a limit, we add a failure chance in spikes of gas price.
| @@ -0,0 +1,656 @@ | |||
| const IPyth = [ | |||
There was a problem hiding this comment.
this is a bit annoying because we have to update it when the contract API changes but i guess it's fine...
One thought is that we could update the the pyth EVM SDK to export an object like this, then import that here. That would also help Pyth users who use viem.
There was a problem hiding this comment.
Isn't this the same as the json exported from the evm sdk? Is this only here like this so that you can get viem type checking to work out?
If that's what it is, I would advise writing and exporting the abi as typescript in the evm sdk and having tooling to generate the json while building the package instead of writing & exporting json directly, because IIUC viem's static typing relies on dependent types and you cannot import json as const in typescript yet. This way, any consumers in typescript could import the .ts extensions, but the .json extension files will still be there for other users and will be identical.
| @@ -0,0 +1,656 @@ | |||
| const IPyth = [ | |||
There was a problem hiding this comment.
Isn't this the same as the json exported from the evm sdk? Is this only here like this so that you can get viem type checking to work out?
If that's what it is, I would advise writing and exporting the abi as typescript in the evm sdk and having tooling to generate the json while building the package instead of writing & exporting json directly, because IIUC viem's static typing relies on dependent types and you cannot import json as const in typescript yet. This way, any consumers in typescript could import the .ts extensions, but the .json extension files will still be there for other users and will be identical.
ali-bahjati
force-pushed
the
price-pusher/use-viem-for-evm
branch
from
d946dba to
b3a66f1
Compare
ali-bahjati
force-pushed
the
price-pusher/use-viem-for-evm
branch
from
1f6736a to
e46c461
Compare
ali-bahjati
force-pushed
the
price-pusher/use-viem-for-evm
branch
from
e46c461 to
d48d298
Compare
Web3 library is not very widely used anymore due to its complex and magical internal design. Some users were reporting issues like strange timeouts or unsupported RPC calls via web3 (and the deprecated HDWalletProvider by truffle that we use). This change refactors the code to use Viem. The experience with Viem is nice: it has strong types and good utilities. The error handling is also very well designed. The downside is that it has a steep learning curve to get it right.
This change refactors the code based on the PR reviews to make it simpler as well.
Lastly the version is bumped as a major release because the behaviour and logs have changed and it might affect production environments. It also signals the users to test it out properly before using it which is good because all the failure cases might not be handled.