test(pulse-scheduler): add gas benchmark #2596
Merged
+470
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Skipped Deployments
|
tejasbadadare
changed the title
jayantk
approved these changes
Apr 21, 2025
tejasbadadare
merged commit b98f257
into
tb/pulse-scheduler/better-subparams-validation
10 checks passed
tejasbadadare
added a commit
that referenced
this pull request
Apr 21, 2025
* feat: add permanent subscriptions, clean up tests * refactor: extract out subscription parameter validation and improve error handling * test(pulse-scheduler): add gas benchmark (#2596) * test(pulse-scheduler): add gas benchmark, refactor common helpers into util * doc: test comment * fix: import * fix: overflow, DRY * doc: comment * fix: remove unused constants * fix: merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PulseSchedulerTestUtils.t.solBenchmarks should be run with -vv to see the gas usage of the operations under test, excluding the setup costs.
See results here: https://app.warp.dev/block/Hs5rmQjIUKvq1X6Sdxl6nw
Rationale
Need it to be able to profile the current and future gas usage of the contract.
How has this been tested?