feat(metrics): add price update delay metric and update method #2619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
ali-bahjati
reviewed
Apr 28, 2025
apps/price_pusher/src/metrics.ts
Outdated
| @@ -14,6 +14,7 @@ export class PricePusherMetrics { | |||
| public lastPublishedTime: Gauge<string>; | |||
| public priceUpdateAttempts: Counter<string>; | |||
| public priceFeedsTotal: Gauge<string>; | |||
| public priceUpdateDelay: Gauge<string>; | |||
There was a problem hiding this comment.
Out of curiosity, why are these string :?
There was a problem hiding this comment.
these are for the label names
…target timestamps
ali-bahjati
reviewed
Apr 28, 2025
apps/price_pusher/src/metrics.ts
Outdated
| registers: [this.registry], | ||
| }); | ||
|
|
||
| this.targetTimestamp = new Gauge({ |
There was a problem hiding this comment.
what's the difference between this and lastPublishedTime ?
There was a problem hiding this comment.
yeah its redundant, i will remove targetTimestamp and use lastPublishedTime instead
ali-bahjati
approved these changes
Apr 28, 2025
|
Ah please bump the version too. |
…lished time logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added a new gauge metric
pyth_price_update_delayto track the delay between source and target timestamps relative to each price feed's configured threshold. The metric is calculated as:Rationale
timeDifferenceconfiguration, making static thresholds suboptimalsourceLatestPricewon't update, keeping the delay constantdelay > 2min) while respecting individual feed configurationsHow has this been tested?
Steps to verify:
sourceLatestPrice.publishTime - targetLatestPrice.publishTimeagainst raw timestampspriceConfigTimeDifferenceThe changes are non-invasive and purely additive to the metrics system, with no impact on core price pushing functionality.