feat(entropy): Split out V2 interface into separate file. #2645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jayantk
commented
May 1, 2025
| address provider | ||
| ) external view returns (EntropyStructsV2.ProviderInfo memory info); | ||
|
|
||
| function getDefaultProvider() external view returns (address provider); |
There was a problem hiding this comment.
note that I moved this function over to IEntropyV2 as well since end users may want to call it
jayantk
commented
May 1, 2025
| /// @return info The provider information including configuration, fees, and operational status | ||
| /// @dev This method returns detailed information about a provider's configuration and capabilities. | ||
| /// The returned ProviderInfo struct contains information such as the provider's fee structure and gas limits. | ||
| function getProviderInfoV2( |
There was a problem hiding this comment.
method docs on this function and below are new
jayantk
commented
May 1, 2025
| @@ -0,0 +1,305 @@ | |||
| [ | |||
| { | |||
| "anonymous": false, | |||
There was a problem hiding this comment.
forgot to commit this ABI previously
m30m
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Split out the V2 functionality into a separate file. The intention is that developers can interact exclusively with the IEntropyV2 interface. This interface hides internal methods for providers etc that users don't need to know about. Meanwhile, we retain the IEntropy interface (which has the old functions + provider functions + inherits the V2 functions) as the full interface the contract implements.
Rationale
These changes should make it easier for users to identify the functionality they need
How has this been tested?