fix(apps/price_pusher) handle price feed removal more gracefully #2730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when a feed is not found, the code throws an error which is typically good but often a feed is removed and that results in the entire push failing. this change adds the flag to ignore invalid price updates, which allows the push to continue.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
ali-bahjati
commented
May 24, 2025
| console.error("Error receiving updates from Hermes:", error); | ||
| eventSource.close(); | ||
| await sleep(5000); // Wait a bit before trying to reconnect | ||
| this.startListening(); // Attempt to restart the listener |
There was a problem hiding this comment.
please note that we have another loop checking for latest price update that crashes if there's no update within last 30 seconds.
ali-bahjati
force-pushed
the
pusher/better-feed-removal-handling
branch
from
2389662 to
9fb34e9
Compare
cctdaniel
approved these changes
May 24, 2025
This was referenced Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The price pusher in many networks would throw an error if a feed doesn't exist and the behaviour was there to prevent config errors but it falls short when we remove a feed. This change adds a warning for non existent feeds but lets the pusher keep functioning (for the remaining feeds).
How has this been tested?
p.s: evm pusher already had the flag to ignore invalid feeds.